remove cryptography version pinning due to paramiko newer than 2.11.0 #1109
Conversation
|
I would like this change as well, as I'm running into some annoying dependency conflicts. |
|
I would like this as well |
|
Any reason why this PR is still blocked? |
| # Pinning cryptography should not be needed after paramiko 2.11.0. | ||
| 'cryptography == 36.0.2', | ||
| # Pinning cryptography is not needed after paramiko 2.11.0. Correct it | ||
| 'cryptography >= 1.0.0', |
There was a problem hiding this comment.
If pinning is not needed, I think we can just delete this line, because we didn't depend on cryptography directly from code.
There was a problem hiding this comment.
I commit this pull request 11 months ago, at that time, I checked the commit history and found that cryptography >= 1.0.0 had been there before, and the version pinning to ==36.0.2 is edited from >= 1.0.0, so I thought it is better to revert to >= 1.0.0 than directly delete it.
Now that 11 months has passed and there are a lot of new commits, if it is better to directly delete this line, I will happily agree with it.
There was a problem hiding this comment.
apologies for the delay 🥺
can you resolve the conflict as well? thanks
There was a problem hiding this comment.
apologies for the delay 🥺
can you resolve the conflict as well? thanks
Do you mean the "Resolve conversation" button below?
There was a problem hiding this comment.
No, I mean, this PR can not be merged now, cause it has conflicts.
Can you rebase from main branch, or resubmit one? thanks.
There was a problem hiding this comment.
No, I mean, this PR can not be merged now, cause it has conflicts.
Can you rebase from main branch, or resubmit one? thanks.
Oh，please allow me some time.
|
Thank you! |
Description
according to pull request #1055 and file setup.py
# Pinning cryptography should not be needed after paramiko 2.11.0.Now that paramiko's version is 3.1.0, arch package python-paramiko version is 2.11.1, both newer than 2.11.0, so remove cryptography version pinning.
Checklist
changelog.md.AUTHORSfile (or it's already there).