CB-6128 add tooltips to tabs #3221
Open
+80
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
reviewed
Feb 4, 2025
Comment on lines
64
to
84
| let tooltip = name; | ||
|
|
||
| if (connection) { | ||
| tooltip += `\n${translate('ui_connection')}: ${connection.name}`; | ||
| } | ||
|
|
||
| if (executionContext) { | ||
| const project = projectInfo.get(executionContext.projectId); | ||
|
|
||
| if (executionContext.defaultCatalog) { | ||
| tooltip += `\n${translate('ui_catalog')}: ${executionContext.defaultCatalog}`; | ||
| } | ||
|
|
||
| if (executionContext.defaultSchema) { | ||
| tooltip += `\n${translate('ui_schema')}: ${executionContext.defaultSchema}`; | ||
| } | ||
|
|
||
| if (project) { | ||
| tooltip += `\n${translate('ui_project')}: ${project.name}`; | ||
| } | ||
| } |
There was a problem hiding this comment.
this part of logic is duplicated, can we move it to separate function-helper that will return tooltip string (localized)
something like getObjectInfoTooltip(translate, connection?, catalog?, schema?, project?)
sergeyteleshev
approved these changes
Feb 7, 2025
|
|
||
| import { useTranslate } from './localization/useTranslate.js'; | ||
|
|
||
| export function useObjectInfoTooltip(connection?: string, catalog?: string, schema?: string, project?: string) { |
There was a problem hiding this comment.
it is already almost a lot arguments. in such cases better to provide 1 argument as an object so it is easier to handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useService is used instead of useResource intentionally. It will decrease amount of calls to the resources. We dont need to force data to be presented (connection and project core entities).