Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver/pro#4035 Local path detect fix. Unit tests #74

Merged
merged 2 commits into from
Feb 3, 2025
Merged

dbeaver/pro#4035 Local path detect fix. Unit tests #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac0ba3c
dbeaver/pro#4035 Local path detect fix. Unit tests
serge-rider Jan 30, 2025
d8d7900
Merge branch 'devel' into 4035-sql-script-tasks
serge-rider Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/org.jkiss.utils/src/org/jkiss/utils/IOUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,18 @@
}


public static boolean isLocalFile(String filePath) {

Check warning on line 442 in modules/org.jkiss.utils/src/org/jkiss/utils/IOUtils.java

View workflow job for this annotation

GitHub Actions / Check / Lint 

[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.

Raw Output:
/github/workspace/./modules/org.jkiss.utils/src/org/jkiss/utils/IOUtils.java:442:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)
return !filePath.contains("://") || filePath.startsWith("file:");
// Local paths:
// rel-path
// /abs/path
// \abs\path
// c:/abs/path
// c:\abs\path
int divPos = filePath.indexOf(":/");
return divPos < 0 || divPos == 1 || filePath.startsWith("file:");
}

public static boolean isLocalURI(URI uri) {

Check warning on line 453 in modules/org.jkiss.utils/src/org/jkiss/utils/IOUtils.java

View workflow job for this annotation

GitHub Actions / Check / Lint 

[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.

Raw Output:
/github/workspace/./modules/org.jkiss.utils/src/org/jkiss/utils/IOUtils.java:453:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)
return uri.getScheme().equals("file");
}

Expand Down