Code refactoring (maintained support for PHP v7.4) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code review w/ GrumPHP tasks Added $queryData argument Removed createPopulateString method Cast cacheTime to integer Moved to PHP 7.4 minimum version Updated README Removed unnecessary createFilterString() method in favor of the more generic $queryData argument
|
Thy @dbfx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review w/ GrumPHP tasks
Added $queryData argument
Removed createPopulateString method
Cast cacheTime to integer
Moved to PHP 7.4 minimum version
Updated README
Removed unnecessary createFilterString() method in favor of the more generic $queryData argument