-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Code refactoring #37
base: master
Are you sure you want to change the base?
Conversation
updated all composer packages restored STRAPI_URL revised esceptions classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The new queryParams means I don't have to re-implement my changes that introduced filters to the collection method.
Hi @dbfx, is there any problem accepting this pull request? |
@frugan-dev We have forked this package over at BRFCS/laravel-strapi because it looks like this repo is deprecated and we needed Laravel 11 support. Feel free to contribute if you still use Laravel & Strapi. We're not on packagist yet though. |
Hi @Stubbs , If you ask for my contribution, you should have included my changes in this PR in your fork.. |
DONE
getResponse()
$response
returned byCache::remember()
https://stackoverflow.com/a/74783008/3929620$response->throw()
Illuminate\Http\Client\RequestException
Http::withToken()
instead ofHttp::withHeaders()
Http::withQueryParameters()
instead ofhttp_build_query()
Http::withOptions()
andHttp::baseUrl()
$type
to$name
, as it is more consistent with the field used by Strapi$queryData
to$queryParams
, as it is more consistent withHttp::withQueryParameters()
$sortKey
,$sortOrder
,$populate
, etc.) in favor of$queryParams
, which allows greater control over the API parameters used$queryParams
also allows you to use pagination by offset values (pagination[start]
andpagination[limit]
), which previously conflicted with pagination by page values (pagination[page]
andpagination[limit]
) set directly within the methodcollection()
$cacheTime
parameter to override the global value defined inSTRAPI_CACHE_TIME
per-callcollectionCount()
method, as the/api/$name/count
entrypoint does not seem to exist anymore in Strapi v4 (?), and also thepagination[withCount]
parameter exists and it's active by defaultentriesByField()
method as it is superfluous, because it is possible to make the same call with thecollection()
method (see examples inREADME
)STRAPI_FULL_URLS
globally in.env
file$pluck
parameter as it is superfluous to the primary functionality of this package: everyone is free to alter the response as they wishconfig('strapi.pagination.limit')
from 20 to 25 (default Strapipagination[pageSize]
)README
fileTODO
README
? this could be included in this section, useful for those who have a local development setup (e.g. mkcert):