new Dialogflow scenario for explainability #16
Conversation
Webhook/components.py
Outdated
| def getComponents(): | ||
| global qanaryComponents | ||
| global qanaryComponentNames | ||
| response = urllib.request.urlopen('http://demos.swe.htwk-leipzig.de:40111/components').read().decode() | ||
| response = urllib.request.urlopen( | ||
| 'http://pie.qanary.net:8000/components').read().decode() |
There was a problem hiding this comment.
Please replace the hard-coded URL by a constant initialized at the beginning of the Python file.
There should be something like:
from decouple import config # required: pip install python-decouple
QANARY_COMPONENTS_ENDPOINT = config('QANARY_COMPONENTS_ENDPOINT')
Then create a file .env for your local environment containing:
QANARY_COMPONENTS_ENDPOINT="http://demos.swe.htwk-leipzig.de:40111/components"
see https://simpleisbetterthancomplex.com/2015/11/26/package-of-the-week-python-decouple.html
There was a problem hiding this comment.
@anbo-de what you are reviewing is an outdated file. If you could please notice the "outdated" label on the file you've left your reviews on. These are old changes. As part of the fix for issue - #17, a .env file was created and all the URLs were added there and the changes were made in all the other files where the constant were imported from .env files. If you could please see the Files tab in this PR, you will be able to find the latest updated file and you will not find direct URLs that you have just reviewed and commented to. Please let me know if you can find it.
There was a problem hiding this comment.
Webhook/helpers/intents.py
Outdated
| defaultComponents = ["NED-DBpediaSpotlight", "SparqlExecuter", | ||
| "OpenTapiocaNED", "BirthDataQueryBuilder", "WikidataQueryExecuter"] | ||
| profileComponents = [] | ||
| vizURL = "https://dbpedia-rdf-viz.herokuapp.com/visualize/" |
There was a problem hiding this comment.
Please externalize value as described for components.py.
There was a problem hiding this comment.
Webhook/helpers/intents.py
Outdated
| return result['results']['bindings'][0]['answer']['value'] | ||
|
|
||
|
|
||
| def getAnswerFromQanary(graphId): | ||
| endpointUrl = 'http://demos.swe.htwk-leipzig.de:40111/sparql' | ||
| endpointUrl = 'http://pie.qanary.net:8000/sparql' |
There was a problem hiding this comment.
Please externalize value as described for components.py.
Webhook/helpers/intents.py
Outdated
| return result['results']['bindings'][0]['answer']['value'] | ||
|
|
||
|
|
||
| def getAnswerFromQanary(graphId): | ||
| endpointUrl = 'http://demos.swe.htwk-leipzig.de:40111/sparql' | ||
| endpointUrl = 'http://pie.qanary.net:8000/sparql' | ||
| output = "No answer available." | ||
| query = """ |
There was a problem hiding this comment.
Remark: better to use format() for inserting the graphId into the query.
Webhook/helpers/intents.py
Outdated
| params = { | ||
| "question": lastKbquestion[sessionId], | ||
| "componentlist[]": show | ||
| } | ||
| response = requests.post( | ||
| 'http://demos.swe.htwk-leipzig.de:40111/startquestionansweringwithtextquestion', params) | ||
| 'http://pie.qanary.net:8000/startquestionansweringwithtextquestion', params) |
There was a problem hiding this comment.
Please externalize value as described for components.py.
Webhook/helpers/intents.py
Outdated
| # lastGraphIdOfSession = None | ||
| explanation = "Sorry, there was no previously asked question in this session." | ||
| # if lastGraphIdOfSession is not None: | ||
| endpointUrl = 'http://pie.qanary.net:8000/sparql' |
There was a problem hiding this comment.
Please externalize value as described for components.py.
COMPLETED
new intent to get explanation of previous answer
request jsons for existing and new intents
#14