Add BQ labels to all BQJobConfigs #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
4 tasks
Alex-Krykun
force-pushed
the
add_bq_labels_to_all_bq_jobs
branch
from
7e9a2f0 to
7a69422
Compare
Alex-Krykun
temporarily deployed
to
dbt-bigquery
GitHub Actions
Inactive
Alex-Krykun
temporarily deployed
to
dbt-bigquery
GitHub Actions
Inactive
Alex-Krykun
commented
Feb 6, 2025
| def test_get_job_labels(self, mock_get_query_comment_labels): | ||
| query_labels = {"key": "value"} | ||
| expected = {**query_labels, "dbt_invocation_id": "uuid4"} | ||
| mock_get_query_comment_labels.return_value = self.connections._labels_from_query_comment( |
There was a problem hiding this comment.
mocking get_labels_from_query_comment to keep the test simple and unit test only get_job_labels, in another case have to create many obj for fully operational BigQueryConnectionManager instance. (https://github.com/dbt-labs/dbt-adapters/blob/main/dbt-bigquery/src/dbt/adapters/bigquery/connections.py#L213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #774
Problem
Some of the jobs in dbt-bigquery adapters don't have BQ labeling.
Solution
Add missing labels attribute to all BQ Job Config objects.
Checklist