Mp/attempt to patch snowflake types #851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #310
docs issue
Problem
If a given column is a complex ARRAY type such as
ARRAY(VARCHAR(16777216))
, the macroget_columns_in_relation
raises an error.In the
SnowflakeColumn
class, we're restricting things artificially by trying to parsing this among other simple types as a LABEL(NUMERIC) type.Solution
Structured types are more generic and require overrides not to go through this parsing song and dance.
We can override at the Snowflake level to avoid disruption the Base Adapter and other adapters which have different type names.
Alternative Considered
I thought about doing more sophisticated parsing here into these types' subtypes. But, this presents a major problem. In particular, we'd be building a Snowflake compliant AST for not much value to the user. Instead, we trust users to employ these types in their columns and that Snowflake will flag any subtyping problems in an intelligent way.
Checklist