Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore adapter-level support for custom constraints #91

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

jtcohen6
Copy link
Contributor

resolves #90

I believe that fixing this bug would enable a workaround for defining tags / masking policies as part of Snowflake model contracts. This has recently come up as a blocking issue for multiple folks internally (see internal slack thread).

Problem

ConstraintType.custom is missing from CONSTRAINT_SUPPORT, leading to a KeyError during process_parsed_constraint.

Solution

Completely ignore "custom" constraints when checking for adapter-specific support in process_parsed_constraint.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@jtcohen6 jtcohen6 changed the title Jerco/fix 90 Ignore adapter-level support for custom constraints Feb 15, 2024
@jtcohen6 jtcohen6 enabled auto-merge (squash) February 19, 2024 12:23
@jtcohen6 jtcohen6 merged commit 9d48e41 into main Feb 19, 2024
6 checks passed
@jtcohen6 jtcohen6 deleted the jerco/fix-90 branch February 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3181] [Bug] ConstraintType.custom doesn't mix with adapter CONSTRAINT_SUPPORT
2 participants