feat: add catalog_name param to AthenaConnection handle #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunofaustino
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88,
svdimchenko and
thenaturalist
as code owners
Jrmyy
changed the title
Jrmyy
approved these changes
Aug 1, 2023
svdimchenko
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
Description
Currently, the Glue catalog value is not being passed as a parameter in the AthenaConnection call.
When attempting to use a catalog other than the default (awsdatacatalog), the following error is displayed:
The solution now includes the addition of the 'catalog_name' parameter to the AthenaConnection handle.
Models used to test - Optional
Checklist