Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid calling cancel method not implemented in PyAthena's connection #385

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix: avoid calling cancel method not implemented in PyAthena's connection #385

merged 2 commits into from
Aug 25, 2023

Conversation

keshihoriuchi
Copy link
Contributor

Description

connection's handle field is PyAthena's Connection instance. This instance doesn't have cancel method. So we should avoid calling it.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 added the enable-functional-tests Label to trigger functional testing label Aug 23, 2023
@svdimchenko svdimchenko merged commit 011b830 into dbt-labs:main Aug 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicor88 nicor88 nicor88 approved these changes

@svdimchenko svdimchenko svdimchenko approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@Jrmyy Jrmyy Awaiting requested review from Jrmyy

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

Assignees
No one assigned
Labels
enable-functional-tests Label to trigger functional testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keshihoriuchi @nicor88 @svdimchenko