-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for S3 Extra arguments in Seed file upload to s3 #397
Conversation
overall the code looks good to me. BTW @nicor88 WDYT about migrating from dev-requirements.txt and dependencies in setup.py to poetry ? It may help with dependencies management. |
@svdimchenko I think that we discussed that with @Jrmyy back then - we decided to use pip with requirements to adapt a bit with the landscape of other dbt adapters - but I'm happy to reconsider to use it again. |
…change parameter name
…add boto3-stubs to dev-requirements
…format README markdown table
…change parameter name
Hi @nicor88 , @svdimchenko - made some changes following the initial review:
|
Description
This M.R. (still in draft) adds a profile parameters adding predefined ExtraArgs when making a call to upload_to_s3, during the seed file upload.
resolve #389
Models used to test - Optional
Checklist