Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dbt-glue LfTagsConfig compatibility #545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kagenihisomi
Copy link

@kagenihisomi kagenihisomi commented Dec 20, 2023

Allow for compatibility with dbt-glue lf_tags_config/tags_table key

https://github.com/aws-samples/dbt-glue/blob/ee2aa88663fd51ffc1ad1a1dbe04321206453386/dbt/adapters/glue/lakeformation.py#L12

In dbt-glue, for table-level LF-tags, "tags_table" key is used. This allows compatibility to use tags_table across both adapters without having to specify different keys

@nicor88
Copy link
Contributor

nicor88 commented Dec 20, 2023

@kagenihisomi please provide a description on what you are "trying" to address, and what lead to your "implementation"!

@nicor88
Copy link
Contributor

nicor88 commented Jan 3, 2024

@kagenihisomi In case you will like to proceed with this PR please fix the CI.

@svdimchenko
Copy link
Contributor

@kagenihisomi could you add the following option for lf-tags config to documentation as well within this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants