Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-399] Crawl and test entire Jinja namespace #10682

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 9, 2024

Resolves

Problem

We need to crawl and verify all the user-accessible Jinja namespaces to ensure that they're exactly as specified.

Solution

  • generate_parser_model_context
  • generate_generate_name_macro_context
  • generate_runtime_model_context
  • generate_runtime_macro_context
  • generate_runtime_unit_test_context
  • generate_test_context
  • generate_base_context
  • generate_schema_yml_context
  • generate_macro_context
  • generate_runtime_docs_context
  • generate_query_header_context
  • generate_secret_context

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (1d3d315) to head (423ffe7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10682      +/-   ##
==========================================
- Coverage   88.92%   86.10%   -2.82%     
==========================================
  Files         180      180              
  Lines       22785    22785              
==========================================
- Hits        20261    19619     -642     
- Misses       2524     3166     +642     
Flag Coverage Δ
integration 86.10% <ø> (-0.14%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.10% <ø> (-2.82%) ⬇️
Integration Tests 86.10% <ø> (-0.14%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant