-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting datetime value for dbt_valid_to when the record is current #10780
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10780 +/- ##
==========================================
- Coverage 89.14% 82.56% -6.59%
==========================================
Files 183 183
Lines 23402 23403 +1
==========================================
- Hits 20862 19322 -1540
- Misses 2540 4081 +1541
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Reminder, we need to unpin the dependency branches before merge. Otherwise this looks good. |
Resolves #10187
Problem
Currently we use a null to indicate that a snapshot record is current. Users would like to use some arbitrary future date to indicate current instead, because it makes some SQL easier.
Solution
Add a new attribute "dbt_valid_to_current", and implement changes in adapters to use it.
Checklist