Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] complete unique and not_null as strings by default #185

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[tests] complete unique and not_null as strings by default #185

merged 2 commits into from
Feb 18, 2025
+4 −23

Conversation

benmosher
Copy link
Contributor

@benmosher benmosher commented Jan 30, 2025 •
edited
Loading

image

Still supports config/where/name for unique:
image

and 🆕 for arbitrary user defined tests:
image

@benmosher benmosher marked this pull request as ready for review January 31, 2025 14:39
@benmosher benmosher requested a review from a team as a code owner January 31, 2025 14:39
joellabes
joellabes approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm into it! Thank youuuu

@benmosher benmosher merged commit 6cdcf81 into main Feb 18, 2025
27 checks passed
@benmosher benmosher deleted the bmo/unique-notnull branch February 18, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmosher @joellabes