Fix limit and config-version types to be integer, not number
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleArk
changed the title
limit and config-version types to be integer, not number
joellabes
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Note: only modifying 'latest' to avoid mutating schemas pertaining to EOL versions.
This is the exact right idea - but note that the json files in the root of the schemas directory are actually from the 1.4 era and before so should be left alone.
Accordingly I think you also missed applying changes to https://github.com/dbt-labs/dbt-jsonschema/blob/main/schemas/latest/dbt_yml_files-latest.json ?
MichelleArk
force-pushed
the
fix-limit-type
branch
from
6843933 to
b658787
Compare
MichelleArk
force-pushed
the
fix-limit-type
branch
from
b658787 to
bc66d78
Compare
joellabes
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limitandconfig-versiontypes are currently mis-typed in these jsonschemas!In dbt-core, these are both actually optional integers:
Note: only modifying 'latest' to avoid mutating schemas pertaining to EOL versions.