Override check schema exists #452
Conversation
…ist_relation_without_caching
…ft into fix_get_relation
…datashared objects of a connected database
| @@ -142,9 +142,6 @@ def _connection_keys(self): | |||
| "schema", | |||
| "sslmode", | |||
| "region", | |||
| "sslmode", | |||
There was a problem hiding this comment.
Is there a reason to remove these? Is it related to this specific change?
| def _get_cursor(self): | ||
| return self.connections.get_thread_connection().handle.cursor() | ||
|
|
||
| def list_schemas(self, database: str, schema: Optional[str] = None) -> List[str]: |
There was a problem hiding this comment.
I would update the associated macro to call this, otherwise any other macro that is using the associated macro would still use the postgres macro, hence pg_ tables.
| return results | ||
|
|
||
| @available | ||
| def check_schema_exists(self, database: str, schema: str) -> bool: |
There was a problem hiding this comment.
Same comment as on list_schemas
| @@ -0,0 +1,5 @@ | |||
| kind: Features | |||
There was a problem hiding this comment.
This is missing a description that identifies the change.
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
resolves #555
Migrating from postgres__list_schema macro and postgres__check_schema_exists macro to directly calling redshift python connector, which has built in metadata calls that retrieve the same information. Redshift_connector call used in this PR is get_schemas.
Description
Checklist
changie newto create a changelog entry