Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAP-796: Add datadog env vars to tox.ini #576

Merged
merged 1 commit into from
Aug 11, 2023
Merged

ADAP-796: Add datadog env vars to tox.ini #576

merged 1 commit into from
Aug 11, 2023

Conversation

mikealfare
Copy link
Contributor

Problem

We were missing env vars in tox for data dog.

Solution

Add them to tox.ini

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare requested a review from a team as a code owner August 11, 2023 21:41
@mikealfare mikealfare requested a review from Fleid August 11, 2023 21:41
@mikealfare mikealfare self-assigned this Aug 11, 2023
@cla-bot cla-bot bot added the cla:yes label Aug 11, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Aug 11, 2023
@mikealfare mikealfare enabled auto-merge (squash) August 11, 2023 21:42
@mikealfare mikealfare merged commit 68afcba into main Aug 11, 2023
20 of 22 checks passed
@mikealfare mikealfare deleted the workflow/data-dog/env-vars branch August 11, 2023 21:49
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@mikealfare @github-actions
add datadog env vars to tox.ini (#576)
52ea3a6 
(cherry picked from commit 68afcba)
This was referenced Aug 11, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@mikealfare @github-actions
add datadog env vars to tox.ini (#576)
07a977b 
(cherry picked from commit 68afcba)
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@mikealfare @github-actions
add datadog env vars to tox.ini (#576)
021c8f8 
(cherry picked from commit 68afcba)
This was referenced Aug 11, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@mikealfare @github-actions
add datadog env vars to tox.ini (#576)
dea8eba 
(cherry picked from commit 68afcba)
mikealfare added a commit that referenced this pull request Aug 12, 2023
@github-actions @mikealfare
add datadog env vars to tox.ini (#576) (#580)
db77c8c 
(cherry picked from commit 68afcba)

Co-authored-by: Mike Alfare <[email protected]>
mikealfare added a commit that referenced this pull request Aug 12, 2023
@github-actions @mikealfare
add datadog env vars to tox.ini (#576) (#579)
bca270a 
(cherry picked from commit 68afcba)

Co-authored-by: Mike Alfare <[email protected]>
mikealfare added a commit that referenced this pull request Aug 12, 2023
@github-actions @mikealfare
add datadog env vars to tox.ini (#576) (#578)
e91d136 
(cherry picked from commit 68afcba)

Co-authored-by: Mike Alfare <[email protected]>
mikealfare added a commit that referenced this pull request Aug 12, 2023
@github-actions @mikealfare
add datadog env vars to tox.ini (#576) (#577)
a000b71 
(cherry picked from commit 68afcba)

Co-authored-by: Mike Alfare <[email protected]>
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@mikealfare
add datadog env vars to tox.ini (dbt-labs#576)
9273869
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Oct 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@Fleid Fleid Awaiting requested review from Fleid Fleid is a code owner automatically assigned from dbt-labs/adapters

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt