Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove import of FieldEncoder from hologram #592

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Remove import of FieldEncoder from hologram #592

merged 2 commits into from
Aug 30, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 30, 2023

resolves #592

Problem

dbt-core removed hologram as a dependency. FieldEncoder was being imported from hologram.

Solution

Remove FieldEncoder and its registered encoder, since it doesn't appear to be used.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner August 30, 2023 20:50
@cla-bot cla-bot bot added the cla:yes label Aug 30, 2023
@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) August 30, 2023 22:00
@colin-rogers-dbt colin-rogers-dbt merged commit e95685f into main Aug 30, 2023
23 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the 592-jsonschema_adjustments branch August 30, 2023 22:02
github-actions bot pushed a commit that referenced this pull request Sep 14, 2023
@gshank @github-actions
Remove import of FieldEncoder from hologram (#592)
7bc071d 
* Remove import of FieldEncoder from hologram

* Update Fixes-20230830-164611.yaml

---------

Co-authored-by: colin-rogers-dbt <[email protected]>
(cherry picked from commit e95685f)
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Closed
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@gshank @colin-rogers-dbt
Remove import of FieldEncoder from hologram (dbt-labs#592)
e16019d 
* Remove import of FieldEncoder from hologram

* Update Fixes-20230830-164611.yaml

---------

Co-authored-by: colin-rogers-dbt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gshank @colin-rogers-dbt @mikealfare