Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user to set debug level via env var #650

Merged
merged 3 commits into from
Oct 30, 2023
Merged

allow user to set debug level via env var #650

merged 3 commits into from
Oct 30, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Oct 30, 2023 •
edited
Loading

This change follows a similar pattern to dbt-snowflake to allow an adapter to configure it's dependencies' logging, this has the added benefit of not having the debug logs for redshift-connector turned on by default during testing.

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner October 30, 2023 17:10
@cla-bot cla-bot bot added the cla:yes label Oct 30, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@colin-rogers-dbt colin-rogers-dbt merged commit 969eaa6 into main Oct 30, 2023
15 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the setLogLevelForRedshiftConnector branch October 30, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/adapters

@mikealfare mikealfare Awaiting requested review from mikealfare

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @McKnight-42