Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-923: Resolve issue where backup parameter was inadvertently considered in configuration change monitoring #657

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

mikealfare
Copy link
Contributor

resolves #621

Problem

The backup parameter is considered in configuration change monitoring. However, we're not currently able to query this parameter from Redshift. As a result, setting backup equal to False always returns a configuration change since the default value is True. This is a problem when on_configuration_change='fail' since the run fails when it should pass.

Solution

Add a functional test demonstrating the issue using the reporter's example. Remove backup from configuration change monitoring.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 3, 2023
@mikealfare mikealfare requested a review from a team as a code owner November 3, 2023 22:36
@cla-bot cla-bot bot added the cla:yes label Nov 3, 2023
@cla-bot cla-bot bot added the cla:yes label Nov 3, 2023
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a curious fix. Thank you for documenting it in the test what's going on.

@mikealfare mikealfare merged commit fe1414f into main Nov 8, 2023
18 checks passed
@mikealfare mikealfare deleted the materialized-views/bug/adap-923 branch November 8, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-923] [Bug] Materialized view config change identification not working
2 participants