Compare contract data types prior to creating the DDL with data types and constraints

[dbeatty10]

resolves #707

Problem

Users get an inscrutable error message if they forget to provide a data_type when enforcing a contract:

23:28:27  Unhandled error while executing 
'data_type'
23:28:27  1 of 1 ERROR creating sql table model dbt_dbeatty_tools.my_model ............... [ERROR in 0.07s]
23:28:28  
23:28:28  Finished running 1 table model in 0 hours 0 minutes and 3.88 seconds (3.88s).
23:28:28  
23:28:28  Completed with 1 error and 0 warnings:
23:28:28  
23:28:28    'data_type'

The root cause is that the order is accidentally backwards here.

It's supposed to be this before this:

    {{ get_assert_columns_equivalent(sql) }}
    {{ get_table_columns_and_constraints() }}

Solution

Flip the order!

To match the order in dbt-postgres, dbt-bigquery, and dbt-snowflake, just flip the order of these two lines:

dbt-redshift/dbt/include/redshift/macros/adapters.sql

Lines 51 to 52 in f95c534

	{{ get_table_columns_and_constraints() }}
	{{ get_assert_columns_equivalent(sql) }}

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc)

[github-actions]

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

[github-actions]

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.