Reduce allocations using unique identifiers of keys as keys in the map #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not. Did you just check if the curent lower bound on OCaml needs updating (4.02) ? |
|
Ah, I had not. It looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recent inclusion in the stdlib (as part of the new Type module) of
Type.Id.uid, it looks like we can always compute a unique integer for type ids.This PR proposes to use this function to: 1) avoid computing
uids separately and storing them along type ids; 2) index the underlying map with uids instead of indexing it using keys (that then need to be boxed).I think this should avoid the allocations mentioned in issue #2, although using a different approach than what is suggested there?