Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package version to 0.32.0 #385

Closed
wants to merge 2 commits into from

Conversation

ahlaughland
Copy link
Contributor

I missed this small detail when submitting my PR.

@ahlaughland ahlaughland changed the title Update package version to 0.31.0 Update package version to 0.32.0 Mar 18, 2024
@ahlaughland
Copy link
Contributor Author

ahlaughland commented Mar 18, 2024

Updated to be 0.32.0 since this PR will update the latest package to v0.32.0

@pieper
Copy link
Collaborator

pieper commented Mar 18, 2024

We haven't been consistent on this version number, rather relying on the semantic commit approach that updates the npm package versions. Seems like people just update now-and-then.

@ahlaughland If you know or can find out the correct policy for how this number should be managed it would be great to add a note to the readme so we can be consistent going forward. Thanks 👍

@ahlaughland
Copy link
Contributor Author

We haven't been consistent on this version number, rather relying on the semantic commit approach that updates the npm package versions. Seems like people just update now-and-then.

@ahlaughland If you know or can find out the correct policy for how this number should be managed it would be great to add a note to the readme so we can be consistent going forward. Thanks 👍

I will take a look and see what I can do. Thanks again!

@ahlaughland
Copy link
Contributor Author

ahlaughland commented Apr 29, 2024

@pieper I looked at a few repos and the version in package.json is typically updated as part of the PR. This is how we do it but mostly not. 😄

OHIF for example, removed version from their package.json and moved it to a version.json file, which they edit with the latest version update - https://github.com/rapidllc/3drd-ohif-v3/blob/main/version.json.

The only recommendation I could make is to manually update version in the DCMJS package.json as part of PR approvals. Other than that the process looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants