Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Netlify app master-dcmjs2 deploy build #392

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

wayfarer3130
Copy link
Contributor

The change uses the URL that built correctly on the last deploy of dcmjs. Looks like it should work this time.

@wayfarer3130 wayfarer3130 requested a review from pieper May 6, 2024 20:17
Copy link

netlify bot commented May 6, 2024

Deploy Preview for dcmjs2 ready!

Name Link
🔨 Latest commit 190b70f
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/66393d36c81c0100094f18e8
😎 Deploy Preview https://deploy-preview-392--dcmjs2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130
Copy link
Contributor Author

@pieper - the last build actually worked for deployment, against:
https://master--dcmjs2.netlify.app
Those examples are live, albeit we are still seeing issues with CORS to the lury back end - I'm not sure who set that data up, if you know if they could update those to allow the examples to actually run that would be good.

@pieper
Copy link
Collaborator

pieper commented May 6, 2024

Thanks @wayfarer3130 - I'm not sure what 'lury' refers to, but it seems to be something @swederik and @JamesAPetts added so maybe they know?

0e1e292

The vtk.js / dicom seg example uses some data of me from IsomicsPublic bucket and the CORS is set correctly there, but there's been some change in dicomweb-client that breaks the ArrayBuffer parsing (it's now an Array with one ArrayBuffer element, where the code is expecting an ArrayBuffer directly - I'm not sure when that behavior came in but it should be easy to fix). I guess now I can just test a fix with the web editor and test it using the netlfy preview - cool!

@pieper pieper merged commit 8f75e74 into master May 6, 2024
14 checks passed
@pieper pieper deleted the fix/netlify-app-url branch May 6, 2024 20:29
Copy link

github-actions bot commented May 6, 2024

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wayfarer3130
Copy link
Contributor Author

@pieper - had to fix a race condition on the download as well so that the failing test now passes consistently.

Copy link

github-actions bot commented May 6, 2024

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants