-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Netlify app master-dcmjs2 deploy build #392
Conversation
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pieper - the last build actually worked for deployment, against: |
Thanks @wayfarer3130 - I'm not sure what 'lury' refers to, but it seems to be something @swederik and @JamesAPetts added so maybe they know? The vtk.js / dicom seg example uses some data of me from IsomicsPublic bucket and the CORS is set correctly there, but there's been some change in dicomweb-client that breaks the ArrayBuffer parsing (it's now an Array with one ArrayBuffer element, where the code is expecting an ArrayBuffer directly - I'm not sure when that behavior came in but it should be easy to fix). I guess now I can just test a fix with the web editor and test it using the netlfy preview - cool! |
🎉 This PR is included in version 0.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@pieper - had to fix a race condition on the download as well so that the failing test now passes consistently. |
🎉 This PR is included in version 0.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The change uses the URL that built correctly on the last deploy of dcmjs. Looks like it should work this time.