Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Open Mesos and Marathon ports #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

timaa2k
Copy link

@timaa2k timaa2k commented Apr 25, 2018

In order to first-class the resilience tests direct access to Mesos and Marathon instances is desired. This is necessary at this point until appropriate DC/OS checks are in place that can be accessed over SSH.

I am aware of the security risk of this change. The resilience tests specify admin_location to be the IP range of the machine executing the tests. However other tests using DC/OS launch might not have such restrictions and for them it may very well be dangerous to expose those ports to the public.

Right now I'm modifying the template in a separate branch in e2e every time DC/OS launch is bumped.

@cprovencher cprovencher requested review from margaret and removed request for mellenburg April 27, 2018 19:32
@cprovencher
Copy link
Member

cprovencher commented Apr 27, 2018

@timaa2k given that this might be a security issue for other dcos-launch use cases where admin_location is not specified, would it be more appropriate to leave this in its separate branch?

@timaa2k
Copy link
Author

timaa2k commented May 8, 2018

I'm not aware of how dcos-launch is currently used in tests, that's why I was raising this issue.
Since it's not a default setting to restrict cluster access I believe not many users secure their cluster.
It may be better to have a separate branch.

@adamtheturtle
Copy link
Contributor

I do not think that supporting Mesosphere use cases is best done by maintaining multiple branches. In my opinion it is best done by supporting options, choosable with Python. Is that viable?

@timaa2k Perhaps link this to a JIRA issue?

@timaa2k
Copy link
Author

timaa2k commented May 8, 2018

Corresponding JIRA issue: https://jira.mesosphere.com/browse/DCOS-28736

@cprovencher
Copy link
Member

@timaa2k @adamtheturtle yeah Adam let's just let's make this a new template and make the usage of those templates configurable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants