Use Option<Duration> for timeouts.
#55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
optional-timeout
branch
8 times, most recently
from
87bc421
to
1bc266a
Compare
reitermarkus
force-pushed
the
optional-timeout
branch
from
1bc266a
to
9bf56fa
Compare
|
@dcuddeback, ping. |
1 similar comment
|
@dcuddeback, ping. |
Please don't do that. I'm busy, and there's no reason your PR should receive priority over anything else on my agenda. |
|
@dcuddeback, please forgive me for being a nag. I don't want preferential treatment, I just hate PRs going stale. I can understand you're busy, I'd volunteer as a collaborator on this project if you'd like, to take some workload off of you. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timeout of
Nonemeans that operations will block indefinitely. This is similar to whatstd::net::TcpStreamdoes.