Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public rates #11

Closed
wants to merge 2 commits into from
Closed

Public rates #11

wants to merge 2 commits into from

Conversation

mbr
Copy link

@mbr mbr commented Mar 5, 2017

Formerly #8. Now includes correct ioctl.

Warnings will disappear if dcuddeback/ioctl-rs#3 is fixed.

mbr added 2 commits March 3, 2017 18:32
Access to these fields is important when setting custom transmission
rates; make them accessible for other libraries.
@dcuddeback
Copy link
Owner

@mbr I'm not sure this crate is the right place for this. This crate is an interface to the POSIX termios API. As pointed out in #9, the termios API implemented in glibc and the ioctl that you're using in this PR use different structs. If we change the definition of the termios struct to work with the ioctl, it would no longer be compatible with the other termios functions. Also, as I mentioned in #8 and dcuddeback/serial-rs#42, making c_ispeed and c_ospeed public in this manner is counter to the portability goals of this library. For a PR to be accepted, it will have to be compatible with those goals.

@dcuddeback dcuddeback closed this Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants