Upgrade to Svelte 5 (#61)

* Upgrade to Svelte 5 * Add retry and trace to playwright tests in CI This gives more context to failures and gives flaky tests a chance to re-run * fix typo in a11y test name * Allow manual launch of playwright tests on GitHub --------- Co-authored-by: Sara Gowen <[email protected]>
dddsw · Nov 20, 2024 · 137fb46 · 137fb46
1 parent bc8d0da
commit 137fb46
Show file tree

Hide file tree

Showing 16 changed files with 162 additions and 163 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -2,6 +2,7 @@ name: Playwright Tests
 on:
   pull_request:
     branches: [main]
+  workflow_dispatch:
 
 jobs:
   test:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,17 +26,17 @@
 		"@types/node": "^22.7.5",
 		"eslint": "^9.12.0",
 		"eslint-config-prettier": "^9.1.0",
-		"eslint-plugin-svelte": "^2.44.1",
+		"eslint-plugin-svelte": "^2.45.1",
 		"globals": "^15.11.0",
 		"husky": "^9.1.6",
 		"lint-staged": "^15.2.10",
-		"prettier": "^3.0.3",
-		"prettier-plugin-svelte": "^3.0.3",
-		"svelte": "^4.2.19",
+		"prettier": "^3.1.0",
+		"prettier-plugin-svelte": "^3.2.6",
+		"svelte": "^5.0.0",
 		"svelte-check": "^4.0.5",
 		"svelte-preprocess": "^6.0.3",
 		"tslib": "^2.3.1",
-		"typescript": "^5.2.2",
+		"typescript": "^5.5.0",
 		"typescript-eslint": "^8.8.1",
 		"vite": "^5.4.8"
 	},

diff --git a/playwright.config.ts b/playwright.config.ts
@@ -20,6 +20,10 @@ export default defineConfig({
 	projects: [
 		{
 			name: 'ci',
+			retries: 1,
+			use: {
+				trace: 'on-first-retry'
+			},
 			testIgnore: 'visual-comparison.spec.ts'
 		},
 		{

diff --git a/src/lib/CallToActions.svelte b/src/lib/CallToActions.svelte
@@ -1,6 +1,10 @@
 <script lang="ts">
 	import type { KeyPoint } from '../types/KeyPoint.type';
-	export let keyPoints: KeyPoint[];
+	interface Props {
+		keyPoints: KeyPoint[];
+	}
+
+	let { keyPoints }: Props = $props();
 </script>
 
 <div class="key-points-container">
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ name: Playwright Tests @@
     on:
       pull_request:
         branches: [main]
+      workflow_dispatch:
     jobs:
       test:
@@ Expand Down @@