Environment output was inside section only intended for runtime.extensions, fixes #54 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolautruche
suggested changes
Nov 9, 2022
Co-authored-by: Jérôme Vieilledent <[email protected]>
rfay
commented
Nov 9, 2022
| @@ -219,18 +222,17 @@ post_install_actions: | |||
| {{ $phpversion := trimPrefix "php:" .platformapp.type }} | |||
| {{ if .platformapp.runtime.extensions }} | |||
| {{ $phpextensions := without .platformapp.runtime.extensions "blackfire" "pdo_pgsql" "sodium" }} | |||
| {{range $extension := $phpextensions }} | |||
| {{range $extension := $phpextensions }} | |||
There was a problem hiding this comment.
Suggested change
| {{range $extension := $phpextensions }} | |
| {{range $extension := $phpextensions }} |
|
Yay, @lolautruche fixed linux :) All green, and now with minor test for PLATFORM_RELATIONSHIPS. |
lolautruche
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was actually happening is there was a misplaced {{end}}, and the result was that environment variables were enclosed in an
if runtime.extensionsblock. And the wordpress-composer template doesn't have any runtime.extensions, so the entire environment section was being omitted.Also added a bit to the wordpress-composer test, to at least check for PLATFORM_RELATIONSHIPS.
This can be tested with
ddev get https://github.com/rfay/ddev-platformsh/tarball/20221108_fix_wp