Set fail_on_hook_faiL: true, fixes #65 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 of the 10 tests fail :( |
|
This may be able to pass tests, but probably not until we load databases for all of them. For example, the Drupal hooks provided by platform require drush to run successfully, and it can't run without a database. |
rfay
force-pushed
the
20221209_fail_on_hook_fail
branch
from
74eb139
to
33a01e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDEV's default these days is not to fail
ddev startif a hook fails, but that doesn't seem quite right in the case of this add-on, where lots of complex things happen (imported from the platform hooks) and hidden failures can cause incomprehensible behavior.This is an experiment at this point, but I think we should consider it. It will be interesting to see what tests it breaks.