-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and simplified ddev config.yml #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! When you like it I like it.
.ddev/config.yaml
Outdated
directory: /var/www/html | ||
hooks: | ||
post-start: | ||
- exec-host: echo -e " NOTICE \n | ||
- exec: bash -c 'while [ ! -f /var/tmp/npminstalldone ]; do sleep 1; done' | ||
- exec: npm run build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this in the daemon startup instead of here? Another &&
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great question, I was going to add it there but npm run build takes 30seconds.
It made me wonder if it broke, it's too long of a wait with no feedback.
Additionally, we only need it the first time since most times we likely be running HMR(hot module reloading anyway, so I added logic for that.
How do I turn the echo -e green? I wanted ${DDEV_PRIMARY_URL}:4321 to be green, but i can't find the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo -e "\e[1;31mHello \e[1;35mWorld"
that works locally, but once it goes through ddev exec it fails.
ddev exec echo -e '\e[1;31mHello \e[1;35mWorld'
e[1
bash: line 1: 31mHello: command not found
Failed to execute command echo -e \e[1;31mHello \e[1;35mWorld: exit status 127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try it in single quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploying ddev-com-front-end with
|
Latest commit: |
0495706
|
Status: | ✅ Deploy successful! |
Preview URL: | https://49f500f3.ddev-com-front-end.pages.dev |
Branch Preview URL: | https://20240314-bmartinez-updated-d.ddev-com-front-end.pages.dev |
It should be good to go now. |
You have some rebasing that needs to be done. |
8304e3e
to
15bc6f9
Compare
config has been rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The Issue
DDEV setup commands where to complex
How This PR Solves The Issue
Simplifies the workflow and provides a better experience out of the box.