Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Astro to 5.1 and its dependencies #293

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

bmartinez287
Copy link
Collaborator

The Issue

Atro 5.1 release dropped this week and it requires a few minor changes on the architecture side.
Most notably there's no slug property is called ID now.

@bmartinez287
Copy link
Collaborator Author

Screenshot 2024-12-19 at 3 01 43 PM So far I'm mostly noticing one bug at compile time. that information on the red square needs to be loaded in a slightly different way.

@bmartinez287
Copy link
Collaborator Author

bmartinez287 commented Dec 19, 2024

I'm not sure why Cloudflare crashed at the beginning of the preview.

Copy link

cloudflare-workers-and-pages bot commented Dec 19, 2024

Deploying ddev-com-front-end with  Cloudflare Pages  Cloudflare Pages

Latest commit: 324cdb7
Status: ✅  Deploy successful!
Preview URL: https://bfdad78b.ddev-com-front-end.pages.dev
Branch Preview URL: https://20241219-bmartinez-upstream.ddev-com-front-end.pages.dev

View logs

@rfay
Copy link
Member

rfay commented Dec 19, 2024

16:39:37.413 | Node.js v18.16.0 is not supported by Astro!
16:39:37.413 | Please upgrade Node.js to a supported version: ">=18.17.1"

I pushed an update to Ubuntu 24.04 for the test runner, but we may need to do something with that as well.

@rfay
Copy link
Member

rfay commented Dec 19, 2024

Changing the .nvmrc to v20 seems to have fixed Cloudflare deployment.

@stasadev
Copy link
Member

Screenshot 2024-12-19 at 3 01 43 PM So far I'm mostly noticing one bug at compile time. that information on the red square needs to be loaded in a slightly different way.

Fixed it with await 324cdb7 (#293)

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you.

I had to delete the project locally using ddev delete -Oy, as HMR wasn't rendering properly. (It might have been a caching issue on my end.)

@bmartinez287
Copy link
Collaborator Author

so I commented out await because it would fail there initially, but it might have been a local glitch of mine because it works now. Yay.

@bmartinez287 bmartinez287 merged commit 2f74a97 into main Dec 20, 2024
2 checks passed
@bmartinez287 bmartinez287 deleted the 20241219_bmartinez_upstream_updates branch December 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants