-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades Astro to 5.1 and its dependencies #293
Conversation
I'm not sure why Cloudflare crashed at the beginning of the preview. |
Deploying ddev-com-front-end with
|
Latest commit: |
324cdb7
|
Status: | ✅ Deploy successful! |
Preview URL: | https://bfdad78b.ddev-com-front-end.pages.dev |
Branch Preview URL: | https://20241219-bmartinez-upstream.ddev-com-front-end.pages.dev |
I pushed an update to Ubuntu 24.04 for the test runner, but we may need to do something with that as well. |
Changing the .nvmrc to v20 seems to have fixed Cloudflare deployment. |
Fixed it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you.
I had to delete the project locally using ddev delete -Oy
, as HMR wasn't rendering properly. (It might have been a caching issue on my end.)
so I commented out await because it would fail there initially, but it might have been a local glitch of mine because it works now. Yay. |
The Issue
Atro 5.1 release dropped this week and it requires a few minor changes on the architecture side.
Most notably there's no slug property is called ID now.