Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more slugs after Astro upgrade, fixes #294 #295

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Dec 23, 2024

The Issue

Also I noticed that there was no links to previous posts at the bottom of the post:

image

How This PR Solves The Issue

Astro replaced slug with id in most places.

Manual Testing Instructions

See https://20241223-stasadev-rss-astro.ddev-com-front-end.pages.dev/blog/rss.xml

Before

<title>DDEV December 2024 Newsletter</title>
<link>https://ddev.com/blog/undefined</link>
<guid isPermaLink="true">https://ddev.com/blog/undefined</guid>
<description>DDEV November 2024 Newsletter</description>
<pubDate>Tue, 03 Dec 2024 00:00:00 GMT</pubDate>

After

<title>DDEV December 2024 Newsletter</title>
<link>https://ddev.com/blog/ddev-dec-2024-newsletter</link>
<guid isPermaLink="true">https://ddev.com/blog/ddev-dec-2024-newsletter</guid>
<description>DDEV November 2024 Newsletter</description>
<pubDate>Tue, 03 Dec 2024 00:00:00 GMT</pubDate>

Bottom navigation is back https://20241223-stasadev-rss-astro.ddev-com-front-end.pages.dev/blog/ddev-dec-2024-newsletter/

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2024

Deploying ddev-com-front-end with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78a8ba6
Status: ✅  Deploy successful!
Preview URL: https://02baad27.ddev-com-front-end.pages.dev
Branch Preview URL: https://20241223-stasadev-rss-astro.ddev-com-front-end.pages.dev

View logs

@stasadev stasadev requested review from rfay and tyler36 December 23, 2024 11:59
@stasadev stasadev changed the title Fix RSS feed after Astro upgrade, fixes #294 Fix more slugs after Astro upgrade, fixes #294 Dec 23, 2024
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thanks!

@stasadev stasadev merged commit 258691d into main Dec 23, 2024
2 checks passed
@stasadev stasadev deleted the 20241223_stasadev_rss_astro branch December 23, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants