fix(node16): Use action/checkout v4 as Node 16 is deprecated #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason not to go forward with this? |
Well, no good reason, I guess. We have 2 "Node 16 deprecated" related errors: 1 for the On the homebrew side, we can't do nothing; and I was waiting for their update: Homebrew/actions#484 So, even if we merge this PR, we will still have an error for the homebrew action. But, as we can't do nothing more, we could definitely merge this one to remove the "action/checkout" deprecation message. I pass this PR in "ready for review". Thanks |
rfay
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
There are warning messages (complaining about Node 16 deprecation) when using this action.
How This PR Solves The Issue
We are updating action/checkout from v3 to v4.
For the Homebrew action, we should just wait for their update:
Homebrew/actions#484
That's why I'm creating this PR as a draft and will change it to "ready for review" when the Homebrew update is available.
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes