fix(keepalive): Run keepalive step only for scheduled run #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thank you for this! Looking forward to seeing it in here.
At this point, even after the upstream change, https://github.com/justafish/ddev-drupal-core-dev/actions/runs/9225132555/job/25381960247 is still failing weirdly.
|
This solved the problems in Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Fixes #32
How This PR Solves The Issue
Add a
github.event_name == 'schedule'condition to run the keepalive stepManual Testing Instructions
I configured one of my repo to use this action with the specific PR commit:
A push on this repo shows that keepalive step has not been triggered :
https://github.com/julienloizelet/ddev-tools/actions/runs/9219045168/job/25363573618
(at the end, there is no mention of the
gautamkrishnar/keepalive-workflow@v2stepA scheduled workflow triggered it:
https://github.com/julienloizelet/ddev-tools/actions/runs/9219156058/job/25363832731
(at the end, we can see that the keepalive API call has been launched:
Kept repo active using the GitHUb API...)