Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Quiet down the brew installs #35

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Oct 11, 2024

The Issue

I was just doing some work on an add-on and saw all the unuseful brew install output, suggest quieting it down.

action.yaml Outdated Show resolved Hide resolved
@julienloizelet
Copy link
Collaborator

Hey @rfay,
thanks for the PR.

I asked my friend ChatGpt about this, and he suggests redirecting only stdout (i.e. >/dev/null) so that errors (and warnings) in stderr remain visible for debugging.

brew tap kaos/shell > /dev/null
brew install bats-core bats-file bats-assert bats-support jq mkcert yq > /dev/null

I didn't test the result, I'm not a stderr/stdout expert, and ChatGpt can be misleading, so what do yo think ?

Thanks

@rfay
Copy link
Member Author

rfay commented Oct 12, 2024

That's what this PR already implements, but it also redirects stderr.

@julienloizelet
Copy link
Collaborator

Shouldn't it be better to keep errors visible ? (for debugging purpose)
Thanks

@rfay
Copy link
Member Author

rfay commented Oct 14, 2024

I removed the stderr redirection, although my own experience is that those don't fail except when there's a network problem or a fundamental problem (like tap or package not being available any more). But there shouldn't be much if anything going to stderr anyway, so should be OK. Thanks so much for caring for this!

@julienloizelet julienloizelet merged commit eed32c4 into main Oct 15, 2024
20 checks passed
@stasadev stasadev deleted the 20241011_quieter_brew_install branch October 15, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants