Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): Exclude release tagged tests for push workflow #38

Merged

Conversation

julienloizelet
Copy link
Collaborator

The Issue

Following this: #37, we want to exclude release tagged tests for push workflow too.

How This PR Solves The Issue

It excludes release tagged tests for push workflow.

Manual Testing Instructions

julienloizelet/ddev-add-on-test@20a7c1489181dae10ce6af9b0680899e2f33c8a2 can be used to test the code coming with this PR.

I've already tested that the result is as expected for

Automated Testing Overview

Related Issue Link(s)

Fixes #37

Release/Deployment Notes

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @julienloizelet, looks good to me.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, thanks!

@julienloizelet julienloizelet merged commit da4d15f into ddev:main Oct 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude also "release" tagged test for "push" workflows
3 participants