-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add game.svg by mind, Voxel, Cellegen & +KZ #32
Conversation
a4ff8c5
to
95bc595
Compare
thats your browser probably, open it in inkscape |
But shouldn't it also looks clean in the browser? |
i assume its firefox? i dont have these glitches in webkit browsers also no, it doesn't need to. We use inkscape to convert the svg. If that works fine its fine |
This still needs the weapon shields if somebody is interested |
Do we have the shields as svg already by any chance? Or were they created as bitmap? |
I dunno, I also dunno why they needed to be added to game skin in first place. Many game skins, that I can find, don't add them xD Guess you can look in ddnet repo and ask the author. |
This isn't about firefox or anything else. I just don't want to start a holy war about whos SVG implementation is correct or not. The ppl that created this file probably used inkscape, and that version of inkscape produced this artifact. If newer inkscape versions don't add these bugs fine, this file needs an update anyway ^^ Edit: Just for fun i tried to convert the svg to png using (https://github.com/linebender/resvg) which claims to have even better SVG support than chrome, and there is also no bug to be observed |
Added missing shields in Jupeyy#1 |
95bc595
to
10bbffc
Compare
@ChillerDragon If you want to fix the preview on your browser last chance. Else I merge as is |
Hmm I still see the glitch. Could you resave it with modern inkscape? |
I already tried that, dunno why it doesn't work for me. Feel free to resave it and force push this pr |
10bbffc
to
28653be
Compare
Yep that fixed it for me in firefox. I used the same inkscape version according to the git diff but somehow I got the magic hands. LGTM from my side ship it. |
i'll leave this draft until the new shield icons on the ddnet repo's game.png is decided