Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add game.svg by mind, Voxel, Cellegen & +KZ #32

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Jupeyy
Copy link
Member

@Jupeyy Jupeyy commented May 8, 2022

i'll leave this draft until the new shield icons on the ddnet repo's game.png is decided

@Jupeyy Jupeyy force-pushed the pr_game_svg_mind_voxel branch from a4ff8c5 to 95bc595 Compare May 8, 2022 08:48
@ChillerDragon
Copy link
Collaborator

How was this made?

This looks gliched

image

@Jupeyy
Copy link
Member Author

Jupeyy commented May 8, 2022

thats your browser probably, open it in inkscape

@ChillerDragon
Copy link
Collaborator

thats your browser probably, open it in inkscape

But shouldn't it also looks clean in the browser?

@Jupeyy
Copy link
Member Author

Jupeyy commented May 8, 2022

i assume its firefox? i dont have these glitches in webkit browsers

also no, it doesn't need to. We use inkscape to convert the svg. If that works fine its fine

@Jupeyy
Copy link
Member Author

Jupeyy commented Nov 3, 2024

This still needs the weapon shields if somebody is interested

@ChillerDragon
Copy link
Collaborator

Do we have the shields as svg already by any chance? Or were they created as bitmap?

@Jupeyy
Copy link
Member Author

Jupeyy commented Nov 3, 2024

I dunno, I also dunno why they needed to be added to game skin in first place. Many game skins, that I can find, don't add them xD

Guess you can look in ddnet repo and ask the author.

@ChillerDragon
Copy link
Collaborator

I am still bothered by the glitch. IMO the textures should not be glitched when viewed in firefox. Resaving it with inkscape on my machine fixes it BTW.

image

@Jupeyy
Copy link
Member Author

Jupeyy commented Nov 4, 2024

IMO the textures should not be glitched when viewed in firefox.

This isn't about firefox or anything else. I just don't want to start a holy war about whos SVG implementation is correct or not. The ppl that created this file probably used inkscape, and that version of inkscape produced this artifact.
inkscape (and apparently also chrome) (still) display it correctly.
So either they use some weird unspecified SVG path not supported by the SVG core spec or firefox is buggy or whatever.
But whatever it is, it's not the users fault, and it's not the users job to investigate about why it happens.

If newer inkscape versions don't add these bugs fine, this file needs an update anyway ^^

Edit: Just for fun i tried to convert the svg to png using (https://github.com/linebender/resvg) which claims to have even better SVG support than chrome, and there is also no bug to be observed

@ChillerDragon
Copy link
Collaborator

Got the shield from cellegen on discord. It is custom but the weapons inside are not. So its just a matter of copy and pasting colors and weapons and aligning it correctly. Sadly the other svg files were lost.

weapon_shield

@M0REKZ
Copy link
Contributor

M0REKZ commented Jan 12, 2025

Added missing shields in Jupeyy#1

@Jupeyy Jupeyy force-pushed the pr_game_svg_mind_voxel branch from 95bc595 to 10bbffc Compare January 12, 2025 10:35
@Jupeyy Jupeyy marked this pull request as ready for review January 12, 2025 10:37
@Jupeyy
Copy link
Member Author

Jupeyy commented Jan 12, 2025

@ChillerDragon If you want to fix the preview on your browser last chance. Else I merge as is

@Jupeyy Jupeyy changed the title Add game.svg by mind & Voxel Add game.svg by mind, Voxel, Cellegen & +KZ Jan 12, 2025
@ChillerDragon
Copy link
Collaborator

Hmm I still see the glitch. Could you resave it with modern inkscape?

@Jupeyy
Copy link
Member Author

Jupeyy commented Jan 12, 2025

Hmm I still see the glitch. Could you resave it with modern inkscape?

I already tried that, dunno why it doesn't work for me. Feel free to resave it and force push this pr

@ChillerDragon ChillerDragon force-pushed the pr_game_svg_mind_voxel branch from 10bbffc to 28653be Compare January 12, 2025 16:12
@ChillerDragon
Copy link
Collaborator

Yep that fixed it for me in firefox. I used the same inkscape version according to the git diff but somehow I got the magic hands.

LGTM from my side ship it.

@Jupeyy Jupeyy merged commit 847eed1 into ddnet:main Jan 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants