Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslated strings #593

Open
amezin opened this issue Oct 17, 2023 · 20 comments
Open

Untranslated strings #593

amezin opened this issue Oct 17, 2023 · 20 comments
Labels
enhancement New feature or request

Comments

@amezin
Copy link
Member

amezin commented Oct 17, 2023

@ddterm/translators

There are missing strings, in every translation. If you plan to fix this, please do it soon - because the next release will likely be the last one supporting GNOME 44 and earlier. After that, users on GNOME 44 and earlier won't receive any updates, including translations.

@amezin amezin added the enhancement New feature or request label Oct 17, 2023
@amezin
Copy link
Member Author

amezin commented Oct 19, 2023

@arnaud-feldmann There are also unreviewed suggestions for the French translation on Weblate

@amezin
Copy link
Member Author

amezin commented Oct 21, 2023

@arnaud-feldmann There are still 2 suggestions not reviewed. Please either accept or reject them.

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@arnaud-feldmann @comradekingu There are still strings marked "fuzzy" in .po files/"Review state: Needs editing" in Weblate (French and Norwegian translations). They won't be used in the UI while they are in this state. If you've already edited them, or they are good as is, please switch them to, at least, "Waiting for review" state/remove "fuzzy" marker in .po file

Also, you could switch strings to "Approved" state. In this case, people outside of ddterm project on Weblate won't be able to edit these strings directly, but will be able to make suggestions. If you mark strings "approved", please make sure you review suggestions on Weblate from time to time.

During initial import to Weblate, I marked entire French translation "approved". @arnaud-feldmann If you don't want to bother with review, you can switch all these words back to "Waiting for review"

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@lcdessantos You're the main contributor to Portugese translation. Are you interested in maintaining it? I've just sent you invitations on both GitHub and Weblate

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@novak-pavel You seem to be the only contributor to Czech translation. I've already sent you invitations, but you've ignored them. Are you interested in maintaining the translation, or are you giving it up?

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@yuhldr You seem to be the only contributor to Chinese translation. I've already sent you invitations, but you've ignored them. Are you interested in maintaining the translation?

@novak-pavel
Copy link
Contributor

novak-pavel commented Oct 22, 2023 via email

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@novak-pavel Ok, I've re-sent you the invitations, to both GitHub org and Weblate

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@rizitis Do you plan to complete Greek translation?

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@gnu-ewm Do you plan to complete Polish translation?

@rizitis
Copy link
Contributor

rizitis commented Oct 22, 2023

I dont know how to translate the rest in Greek. The safe choice imo if someone else dont translate them is to stay in English...

@comradekingu
Copy link
Member

@amezin #593 (comment)
Review isn't turned on for nb_NO, nor should it be.
Locking down translations on the assumption that person 2 doesn't have better ideas is a false assumption about who person 1 has to be.

I can't mark anything as needing review, and https://hosted.weblate.org/access/gnome-shell-extension-ddterm/#users isn't available to me.
Maybe I am not a reviewer, but then again that is a question of who can gauge whether I should be.
I am not able to do it for enough languages to manage anything. It mistakes verifiability for the ability to assign blame.

Opening up something to the gauntlet of potentially malicious people is still far better than discarding all changes that don't go through the "verified" chain of command.

If you turn on direct editing it is easy to make suggestions for source strings.
That way we can deal with the strings that aren't good.
Typically it will be the same strings for every translation, which can either be the ones not translated, marked one way or the other, or translated last.

@ghost
Copy link

ghost commented Oct 22, 2023

@amezin yes

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

@comradekingu I meant "Waiting for review" here

image

There are 13 strings in "Needs editing" state in Norwegian translation, they will be missing from UI - because it translates into "fuzzy" marker for gettext (and "Waiting for review" there is "ready, translated, not locked").

I'll look what can I do about source strings. Will Weblate edit .pot file in PRs if I enable direct editing?

@amezin
Copy link
Member Author

amezin commented Oct 22, 2023

And @comradekingu

Review isn't turned on for nb_NO, nor should it be.
Locking down translations on the assumption that person 2 doesn't have better ideas is a false assumption about who person 1 has to be.

I don't insist on locking down (i. e. marking strings "approved"). If you want, you do it, if you don't want, you don't. It's up to the translator(s).

@amezin
Copy link
Member Author

amezin commented Oct 23, 2023

I've just noticed that "file:", "news:", "man:" URL scheme names were translated in some translations - while they shouldn't be. I didn't put them in quotes, so it's my mistake, at least partially.

I tried to correct this where it seemed obvious (in most translations) - but please double-check, maybe I used wrong quotes, for example.

@yuhldr I have no idea how to fix Chinese translation, you'll have to do it yourself.

Excuse me for the noise.

@amezin
Copy link
Member Author

amezin commented Oct 23, 2023

@rizitis

I dont know how to translate the rest in Greek. The safe choice imo if someone else dont translate them is to stay in English...

If the issue is that there's not enough context - you may try to use Weblate. It shows a corresponding screenshot for almost every string, and, sometimes, additional comments. Also, most of the UI duplicates GNOME Terminal - so looking at it could help too.

@amezin
Copy link
Member Author

amezin commented Oct 25, 2023

@comradekingu I've enabled https://docs.weblate.org/en/latest/workflows.html#source-reviews - it should allow reporting issues/suggestions for source strings

@amezin
Copy link
Member Author

amezin commented Oct 25, 2023

Thanks everyone, I've uploaded v47 to extensions.gnome.org. If everything goes well, it will be the last release for "old" GNOME versions. After it passes the review, I'll switch master branch to gnome45.

If somebody will complete another translation in few next days, it should be possible to upload another gnome 44 release (Polish, Portugese and Czech are close to completion, but still not 100%).

@novak-pavel @comradekingu Could you accept the invitation on Weblate, please?

@amezin amezin closed this as completed Oct 25, 2023
@amezin
Copy link
Member Author

amezin commented Feb 15, 2024

Dear @ddterm/translators, please check your translations for missing/untranslated strings.

Currently, only Chinese translation is 100% complete.

I plan to release a new version with all fix/feature backports for GNOME 40-44, so it would be really nice to have complete translations too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants