Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix to issue #74. Minor code cleanup. #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dpeschel
Copy link

Proposed fix:

  1. When you have not typed the command character, and you type any unhandled special key, such as F20 or clear all tabs or help, mtm ignores it.

  2. When you have typed the command character, and you type any unhandled key (special or not), mtm cancels the command.

  3. Then the BAILOUT key becomes unnecessary because all unknown keys bail out. (So the code and the configuration files should not define it.) And the manual should say explicitly that all unknown keys bail out.

Cleanup:

Added blank lines, removed extra semicolons, changed comma operator to two separate statements.

Proposed fix:

1. When you have not typed the command character, and you type any
   unhandled special key, such as F20 or clear all tabs or help,
   mtm ignores it.

2. When you have typed the command character, and you type any
   unhandled key (special or not), mtm cancels the command.

3. Then the BAILOUT key becomes unnecessary because all unknown
   keys bail out. (So the code and the configuration files should not
   define it.) And the manual should say explicitly that all unknown
   keys bail out.

Cleanup:

Added blank lines, removed extra semicolons, changed comma operator
to two separate statements.
@dpeschel dpeschel marked this pull request as ready for review November 10, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant