Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precice to v3. #167

Closed
wants to merge 1 commit into from
Closed

Update precice to v3. #167

wants to merge 1 commit into from

Conversation

marcfehling
Copy link
Member

Let's see if coupled_laplace_problem is happy.

@marcfehling
Copy link
Member Author

Unfortunately not :-(

[ 25%] Building CXX object CMakeFiles/coupled_laplace_problem.dir/coupled_laplace_problem.cc.o
/__w/code-gallery/code-gallery/coupled_laplace_problem/coupled_laplace_problem.cc:31:10: fatal error: precice/SolverInterface.hpp: No such file or directory
   31 | #include <precice/SolverInterface.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

@bangerth
Copy link
Member

bangerth commented Feb 4, 2024

Do we know who we'd have to tag?

@marcfehling
Copy link
Member Author

@davidscn -- We just tried out to update the precice version to the latest one, and it turns out that there are some incompatibilities with your code gallery program coupled_laplace_problem.

What is your intention with the code gallery program? Would you like to maintain compatibility with precice 2, or do you plan to have it running with v3? If so, would you help us making it compatible with v3?

This has no high priority, so don't feel obliged to address it right away. Your code still runs fine with precice 2 :)

Follow-up to #140.

@davidscn
Copy link
Contributor

davidscn commented Feb 6, 2024

What is your intention with the code gallery program? Would you like to maintain compatibility with precice 2, or do you plan to have it running with v3? If so, would you help us making it compatible with v3?

Updating to v3 seems a good idea, as it comes with major improvements in terms of internals and the API (unbiased opinion). WIP: #168

@marcfehling marcfehling mentioned this pull request Feb 7, 2024
3 tasks
@marcfehling
Copy link
Member Author

Superseded by #168

@marcfehling marcfehling deleted the precice branch February 21, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants