bibtool: enable sorting #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Sep 9, 2022
|
To be clear, the patch doesn't just enable sorting, it actually does the sorting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #389. Follow-up to #391.
This PR enables the
sortfeature ofbibtool. In the previous PR, we only adjusted the citekeys and the general formatting. Now, we enable the default sorting mechanism, which is sorting by the citekey.I haven't checked if all entries are preserved. But a good indicator that we only move code around is that the number of additions equals the number of deletions (plus the two lines in the configuration file).