DBZ-7722 Performance improve in KafkaRecordEmitter class #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete synchronized block in KafkaRecordEmitter class to improve performance and use kafka producer callback. make FileOffsetWriter class operations async.
jpechane
reviewed
Apr 4, 2024
core/src/main/java/io/debezium/connector/cassandra/FileOffsetWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/debezium/connector/cassandra/FileOffsetWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/debezium/connector/cassandra/FileOffsetWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/debezium/connector/cassandra/KafkaRecordEmitter.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/debezium/connector/cassandra/FileOffsetWriterTest.java
Outdated
Show resolved
Hide resolved
change OffsetWriter methods to return Future object to use async approaches. use ElapsedTimeStrategy in PeriodicFlushOffsetPolicy class. use io.debezium.util.Threads in FileOffsetWriter class.
|
@samssh Applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete synchronized block in KafkaRecordEmitter class to improve performance and use kafka producer callback. make FileOffsetWriter class operations async.