Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To make Kafka accessible from IDE on port 9093 #223

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kmozaid
Copy link

@kmozaid kmozaid commented May 20, 2022

No description provided.

@jpechane
Copy link
Contributor

@kmozaid Hi, thanks for the PR

  • Is it ok to advertise endpoint that is not accessible for some of the clients?
  • WOuld it be possible to introduce the same change into all tutorial composes?

@kmozaid
Copy link
Author

kmozaid commented May 23, 2022

@kmozaid Hi, thanks for the PR

  • Is it ok to advertise endpoint that is not accessible for some of the clients?
  • WOuld it be possible to introduce the same change into all tutorial composes?

HI @jpechane

  • The endpoint EXTERNAL://localhost:9093 is advertised so that clients on docker host can access Kafka running in docker. If we specify this external endpoint then we also need to advertise endpoint for internal service like kafka connect (The endpoint CLIENT://kafka:9092 is for Kafka Connect Docker).
  • Sure, I can update other docker-compose files.

@rk3rn3r
Copy link
Member

rk3rn3r commented May 23, 2022

Quick question: Is it valuable to map to a static port? Won't this conflict with multiple containers running concurrently? Would it be possible to use random ports and map the config in the entrypoint script?
Else, we should at least mind in the docs that this can conflict and running the same container multiple times isn't supported.
wdyt @jpechane ?

@OneCricketeer
Copy link

OneCricketeer commented Jul 27, 2022

Won't this conflict with multiple containers running concurrently

Yes.

possible to use random ports and map the config in the entrypoint script

advertised.listeners needs to have a static value, albeit one could be dynamically generated, but then how would compose or the Dockerfile expose that random value without defining it statically in those configs?

@kmozaid
Copy link
Author

kmozaid commented Feb 10, 2023

@OneCricketeer and @jpechane Sorry for the very late update on this PR, please review once again, I have made the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants