Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ukrainian lang #7252

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix: update ukrainian lang #7252

merged 3 commits into from
Jul 29, 2024

Conversation

olegfedak
Copy link
Contributor

@olegfedak olegfedak commented Jul 11, 2024

Discovery
I noticed that there are two folders with the Ukrainian language: ua and uk. Since the international code is uk, I updated it.

Changes
Updates include minor changes, but extend to the fullest translation possible in Decap. If I've missed nothing.

Note
Also, it will be necessary to update node-polyglot as the latest v2.5.0 does not support Ukrainian and plurarizations in it. Currently, the polyglot.js maintainers merged my PR with the language update. I hope that the new version will already support Ukrainian.

upd: node-polyglot 2.6.0 is now available! 🎉

@martinjagodic
Copy link
Member

@olegfedak can you update node-polyglot also then?

@olegfedak olegfedak marked this pull request as ready for review July 14, 2024 23:07
@olegfedak olegfedak requested a review from a team as a code owner July 14, 2024 23:07
@martinjagodic martinjagodic merged commit 9881de0 into decaporg:main Jul 29, 2024
9 checks passed
@olegfedak olegfedak deleted the lang branch August 3, 2024 17:32
martinjagodic pushed a commit that referenced this pull request Aug 5, 2024
* fix: update ukrainian lang

* fix: run format

* fix: update  node-polyglot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants