Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eslint standard with trailing commas #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ekoeryanto
Copy link
Contributor

No description provided.

@erquhart
Copy link
Contributor

Awesome, thanks for this @ekoeryanto - do we pass linting currently? If you add a lint task and have it run before builds we can take a look at the results.

@ekoeryanto
Copy link
Contributor Author

yes we pass the lint currently, but i missing the babel-eslint to make it work with static property, but as the current code is not using that, it already pass.

and yes, I also missing the npm script there, I'll try to add the lint task and make it run before build

@erquhart
Copy link
Contributor

That'd be great, thanks!

@ekoeryanto
Copy link
Contributor Author

ekoeryanto commented Apr 12, 2018

the react/prop-types rule is set to warn, is it better to turn that off ?
see #66

@erquhart
Copy link
Contributor

I'd say so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants