Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing Props from sections/WishlistGallery #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marjoripomarole
Copy link

What is this contribution about?

While running deno task check, I got:

deno task check                                                                                                                       [14:59:18]
Task check deno fmt && deno lint && deno check dev.ts main.ts
Checked 97 files
Checked 89 files
Check file:///Users/marjoripomarole/projects/deco/fashion/dev.ts
Check file:///Users/marjoripomarole/projects/deco/fashion/main.ts
error: TS2614 [ERROR]: Module '"file:///Users/marjoripomarole/projects/deco/fashion/components/wishlist/WishlistGallery.tsx"' has no exported member 'Props'. Did you mean to use 'import Props from "file:///Users/marjoripomarole/projects/deco/fashion/components/wishlist/WishlistGallery.tsx"' instead?
export type { Props } from "deco-sites/fashion/components/wishlist/WishlistGallery.tsx";
              ~~~~~
    at file:///Users/marjoripomarole/projects/deco/fashion/sections/WishlistGallery.tsx:2:15

Doesn't look like sections/WishlistGallery.tsx needs to export Props. So I am removing this line.

How to test it?

After fix:

marjoripomarole➜projects/deco/fashion(wishlist-gallery✗)» deno task check                                                                                                                       [14:59:11]
Task check deno fmt && deno lint && deno check dev.ts main.ts
Checked 97 files
Checked 89 files

@marjoripomarole
Copy link
Author

Would be interesting to have deno task check run as a bot on every Pull Request or Github Action post commit

@marjoripomarole
Copy link
Author

@tlgimenes maybe this is already not revelant. Feel free to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant