Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This feature improves the store's experience and perceived performanc… #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brendonguedes
Copy link

@brendonguedes brendonguedes commented Jun 15, 2023

What is this contribution about?

This feature improves the store's experience and perceived performance through loading placeholders.

How to test it?

Skeletons are like an element's or section's wireframe. It's a placeholder that simulates the layout of these elements/sections while data is being loaded.

Instead of showing a blank page, displaying Skeletons while loading content makes the user feel like the store is more responsive and faster.

Extra info

Also by using Skeletons the store will be less likely to experience Cumulative Layout Shilf (or CLS)(opens in a new tab).

Import:

import Skeleton from "$store/components/ui/Skeleton.tsx";

Usege:

<Skeleton variant="rect" width={140} height={140} />
<Skeleton variant="circle" width={140} height={140} />
<Skeleton variant="text" />

image

@gustavo-vasconcellos
Copy link
Collaborator

@brendonguedes are there any behavior or performance comparison between the nowadays components and some component that uses this Skeleton?
I asks because you didnt implement any use of it on Fashion components 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants